Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing dmi facts when we use dmidecode #68756

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Add some missing dmi facts when we use dmidecode #68756

merged 1 commit into from
Apr 9, 2020

Conversation

relrod
Copy link
Member

@relrod relrod commented Apr 7, 2020

SUMMARY

On OSes where we fall back to dmidecode (freebsd and linux currently),
add some missing fields that dmidecode provides when it is able.

Closes #59317.

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

facts

@relrod relrod requested review from sivel and bcoca April 7, 2020 18:31
@relrod
Add some missing dmi facts when we use dmidecode
2f9e59f 
On OSes where we fall back to dmidecode (freebsd and linux currently),
add some missing fields that dmidecode provides when it is able.

Closes ansible#59317.

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bsd BSD community core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 7, 2020
@relrod relrod requested a review from mattclay April 8, 2020 08:56
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Apr 8, 2020
@relrod relrod merged commit 9b43a57 into ansible:devel Apr 9, 2020
@ansible ansible locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@sivel sivel Awaiting requested review from sivel

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bsd BSD community core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible facts include moterboard serial number
3 participants
@relrod @mattclay @ansibot